Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add correct Estonian relativeTime locale for past and future tense #790

Merged
merged 4 commits into from Jan 30, 2020

Conversation

HarlesPilter
Copy link
Contributor

Since #767 got merged, I added correct future tense for Estonian locale.

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #790 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #790   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       156    156           
  Lines      1107   1111    +4     
  Branches    202    205    +3     
===================================
+ Hits       1107   1111    +4
Impacted Files Coverage Δ
src/locale/et.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144c2ae...33905ae. Read the comment docs.

src/locale/et.js Outdated
function relativeTimeWithTense(number, withoutSuffix, key, isFuture) {
const format = {
s: ['mõne sekundi', 'mõni sekund', 'paar sekundit'],
ss: ['%d sekundi', '%d sekundit'],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we don't need this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wondered why that was there since I don't think moment uses it either.

@iamkun iamkun merged commit d8e0f45 into iamkun:dev Jan 30, 2020
iamkun pushed a commit that referenced this pull request Feb 4, 2020
## [1.8.20](v1.8.19...v1.8.20) (2020-02-04)

### Bug Fixes

* Add Bislama Locale (bi) ([#780](#780)) ([9ac6ab4](9ac6ab4))
* Fix weekOfYear plugin to support yearStart locale for better week number result ([#769](#769)) ([f00db36](f00db36))
* Update et (Estonian) locale relativeTime ([#790](#790)) ([d8e0f45](d8e0f45))
* Update LocaleData plugin to support dayjs.localeData().weekdays() API ([287fed6](287fed6)), closes [#779](#779)
* Update LocaleData plugin to support dayjs.months dayjs.weekdays API ([144c2ae](144c2ae)), closes [#779](#779)
* Update pl locale fusional config ([d372475](d372475))
@iamkun
Copy link
Owner

iamkun commented Feb 4, 2020

🎉 This PR is included in version 1.8.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Feb 4, 2020
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.20](iamkun/dayjs@v1.8.19...v1.8.20) (2020-02-04)

### Bug Fixes

* Add Bislama Locale (bi) ([#780](iamkun/dayjs#780)) ([9ac6ab4](iamkun/dayjs@9ac6ab4))
* Fix weekOfYear plugin to support yearStart locale for better week number result ([#769](iamkun/dayjs#769)) ([f00db36](iamkun/dayjs@f00db36))
* Update et (Estonian) locale relativeTime ([#790](iamkun/dayjs#790)) ([d8e0f45](iamkun/dayjs@d8e0f45))
* Update LocaleData plugin to support dayjs.localeData().weekdays() API ([287fed6](iamkun/dayjs@287fed6)), closes [#779](iamkun/dayjs#779)
* Update LocaleData plugin to support dayjs.months dayjs.weekdays API ([144c2ae](iamkun/dayjs@144c2ae)), closes [#779](iamkun/dayjs#779)
* Update pl locale fusional config ([d372475](iamkun/dayjs@d372475))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.20](iamkun/dayjs@v1.8.19...v1.8.20) (2020-02-04)

### Bug Fixes

* Add Bislama Locale (bi) ([#780](iamkun/dayjs#780)) ([9ac6ab4](iamkun/dayjs@9ac6ab4))
* Fix weekOfYear plugin to support yearStart locale for better week number result ([#769](iamkun/dayjs#769)) ([f00db36](iamkun/dayjs@f00db36))
* Update et (Estonian) locale relativeTime ([#790](iamkun/dayjs#790)) ([d8e0f45](iamkun/dayjs@d8e0f45))
* Update LocaleData plugin to support dayjs.localeData().weekdays() API ([287fed6](iamkun/dayjs@287fed6)), closes [#779](iamkun/dayjs#779)
* Update LocaleData plugin to support dayjs.months dayjs.weekdays API ([144c2ae](iamkun/dayjs@144c2ae)), closes [#779](iamkun/dayjs#779)
* Update pl locale fusional config ([d372475](iamkun/dayjs@d372475))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants