feat:add plugin objectSupport #887

zerooverture · 2020-04-27T12:31:20Z

add/set/subtract support Object parameter
and constructor support Object parameter

The related unit tests have been added.

add/set/subtract support Object parameter and constructor support Object parameter

codecov · 2020-04-27T12:33:00Z

Codecov Report

Merging #887 into dev will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #887   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          164       165    +1     
  Lines         1341      1385   +44     
  Branches       281       295   +14     
=========================================
+ Hits          1341      1385   +44

Impacted Files	Coverage Δ
src/plugin/objectSupport/index.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db642ac...83f3206. Read the comment docs.

iamkun · 2020-04-28T03:01:13Z

src/plugin/objectSupport/index.js

+    oldParse.bind(this)(cfg)
+  }
+
+  proto.setObject = function (argument) {


seems no need to put it on the proto, just a simple function will be better.

you are right.

iamkun · 2020-04-28T04:20:20Z

Help us keeping 100% test coverage https://github.com/iamkun/dayjs/blob/dev/CONTRIBUTING.md

zerooverture · 2020-04-28T11:44:04Z

Help us keeping 100% test coverage https://github.com/iamkun/dayjs/blob/dev/CONTRIBUTING.md
have already accomplished

iamkun · 2020-04-29T03:01:38Z

types/plugin/objectSupport.d.ts

+declare module 'dayjs' {
+    interface Dayjs {
+        set(argument: object): Dayjs
+        add(argument?: object): Dayjs


why a ? here?

sorry, I was careless.processed.

sorry, I was careless

iamkun · 2020-04-29T04:13:35Z

src/plugin/objectSupport/index.js

+   */
+  const parseObjectArgument = (d, utc) => parseArrayArgument([
+    0,
+    d.y || d.year || d.years || 1970,


check our this.$utils().p() prettyUnit to better handle this.

Their role is different, d is input by the user
d => { years: 2010, months: 1, days: 14, hours: 15, minutes: 25, seconds: 50, milliseconds: 125 }
or
d => { y: 2010, M: 1, d: 14, h: 15, m: 25, s: 50, ms: 125 }
I don't have to judge units, just need to get the value of some units, just like the REGEX_PARSE in constant.js.
This code is similar to the part in index.js where parseDate handles strings.
const d = date.match(C.REGEX_PARSE) In the index.js 60 lines

https://github.com/iamkun/dayjs/blob/dev/src/plugin/duration/index.js#L42

Something like this to process all kinds of user input.

Is that right? But it doesn't support date-> dayjs({date:1})

1 you can get prettyUnit from this.$utils().p instead of important it directlly.

2 you may have to extend a new prettyUnit function to treat day and date key both mean day-of-the-month. like https://github.com/iamkun/dayjs/blob/dev/src/plugin/duration/index.js#L26

Is that all right?

Thank you, seniors, let me learn a lot.
This is my first PR. Thanks♪(･ω･)ﾉ

You are most welcome, cheers.

iamkun · 2020-04-29T08:14:38Z

src/plugin/objectSupport/index.js

+        $d.millisecond || 0
+      ]
+      if (utc) return new Date(Date.UTC(...arr))
+      return new Date(...arr)


please avoid using this ...arr advanced es6 syntax, this will hugely increase the bundle size

It seems much smaller now in packed

iamkun · 2020-04-29T09:26:53Z

src/plugin/objectSupport/index.js

+
+  const oldParse = proto.parse
+  proto.parse = function (cfg) {
+    // console.log(cfg)


no test code, pls.

iamkun · 2020-04-29T11:03:04Z

src/plugin/objectSupport/index.js

+    return chain
+  }
+
+  const subtractObject = function (argument) {


these three functions could be combined into one function with different arguments

iamkun · 2020-04-29T11:06:54Z

src/plugin/objectSupport/index.js

+    return oldAdd.bind(this)(number, string)
+  }
+  const oldSubtract = proto.subtract
+  proto.subtract = function (number, string) {


substract could be implemented as negative add, subtract { day: 1 } => add { day: 1 * -1 }, so that we could only care add and set logic

the three methods have been merged into one.

This reverts commit 46ecb61

iamkun · 2020-04-30T03:42:26Z

src/plugin/objectSupport/index.js

+  }
+
+  const oldSet = function (int, string) {
+    return this.clone().$set(string, int)


why a copy-paste instead of proto.set

here I've changed the set to have the same parameter location as add, otherwise you have to judge in callObject, which is inefficient and increases the package size.
or set and add can't share a callObject.

also, my attempt to use proto.set in oldSet will cause a dead loop because proto.set is redirected.
Using 'proto.$set' has the problem of the 'this' scope.

Oh I see, why useing return proto.set will cause a dead loop?

const oldSet = function (int, string) { return proto.set(string, int) } ... proto.set = function (string, int) { ... }

his code causes oldSet to enter the newly defined proto.set each time, So it creates a dead loop.

In the new code, I direct used a callback to solve this pointing problem.

## [1.8.27](v1.8.26...v1.8.27) (2020-05-14) ### Bug Fixes * Add Kinyarwanda (rw) locale ([#903](#903)) ([f355235](f355235)) * Add plugin objectSupport ([#887](#887)) ([52dfb13](52dfb13)) * Add Turkmen (tk) locale ([#893](#893)) ([a9ca8dc](a9ca8dc)) * Fix CustomParseFormat plugin set locale error ([#896](#896)) ([8035c8a](8035c8a)) * Fix locale month function bug ([#908](#908)) ([bf347c3](bf347c3)) * Update CustomParseFormat plugin to support Array formats ([#906](#906)) ([97856c6](97856c6))

iamkun · 2020-05-14T08:12:19Z

🎉 This PR is included in version 1.8.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [1.8.27](iamkun/dayjs@v1.8.26...v1.8.27) (2020-05-14) ### Bug Fixes * Add Kinyarwanda (rw) locale ([#903](iamkun/dayjs#903)) ([f355235](iamkun/dayjs@f355235)) * Add plugin objectSupport ([#887](iamkun/dayjs#887)) ([52dfb13](iamkun/dayjs@52dfb13)) * Add Turkmen (tk) locale ([#893](iamkun/dayjs#893)) ([a9ca8dc](iamkun/dayjs@a9ca8dc)) * Fix CustomParseFormat plugin set locale error ([#896](iamkun/dayjs#896)) ([8035c8a](iamkun/dayjs@8035c8a)) * Fix locale month function bug ([#908](iamkun/dayjs#908)) ([bf347c3](iamkun/dayjs@bf347c3)) * Update CustomParseFormat plugin to support Array formats ([#906](iamkun/dayjs#906)) ([97856c6](iamkun/dayjs@97856c6))

feat add plugin objectSupport

954db86

add/set/subtract support Object parameter and constructor support Object parameter

zerooverture changed the title ~~feat add plugin objectSupport~~ feat:add plugin objectSupport Apr 27, 2020

zerooverture mentioned this pull request Apr 27, 2020

feat:add/set/subtract support Object parameter #886

Closed

iamkun reviewed Apr 28, 2020

View reviewed changes

zerooverture added 2 commits April 28, 2020 11:57

refactor:remove unnecessary proto methods

89596ca

refactor:remove unnecessary proto methods

5963241

fix:action scope of this

9e8fef1

iamkun reviewed Apr 29, 2020

View reviewed changes

fix:remove unnecessary symbols

1487db5

sorry, I was careless

iamkun reviewed Apr 29, 2020

View reviewed changes

zerooverture added 2 commits April 29, 2020 14:49

refactor:optimized parseDate code

fe7fb05

refactor:optimized code

7d7db50

iamkun reviewed Apr 29, 2020

View reviewed changes

zerooverture added 2 commits April 29, 2020 16:24

refactor:removed ...arr

60f59be

refactor:reduce the compression

460e312

iamkun reviewed Apr 29, 2020

View reviewed changes

test:add default year,month,date

fa8528d

iamkun reviewed Apr 29, 2020

View reviewed changes

zerooverture added 3 commits April 29, 2020 22:57

refactor:redundant methods

b9f7f46

test:relativeTime line 23 covered

46ecb61

Revert "test:relativeTime line 23 covered"

3c51c1c

This reverts commit 46ecb61

iamkun reviewed Apr 30, 2020

View reviewed changes

refactor:optimized code

83f3206

iamkun merged commit 52dfb13 into iamkun:dev Apr 30, 2020

iamkun added the released label May 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat:add plugin objectSupport #887

feat:add plugin objectSupport #887

zerooverture commented Apr 27, 2020

codecov bot commented Apr 27, 2020 •

edited

Loading

iamkun Apr 28, 2020

zerooverture Apr 28, 2020

iamkun commented Apr 28, 2020

zerooverture commented Apr 28, 2020

iamkun Apr 29, 2020

zerooverture Apr 29, 2020

iamkun Apr 29, 2020

zerooverture Apr 29, 2020

iamkun Apr 29, 2020 •

edited

Loading

zerooverture Apr 29, 2020

iamkun Apr 29, 2020

zerooverture Apr 29, 2020

iamkun Apr 29, 2020

zerooverture Apr 29, 2020

iamkun Apr 29, 2020

iamkun Apr 29, 2020

zerooverture Apr 29, 2020

iamkun Apr 29, 2020

iamkun Apr 29, 2020

iamkun Apr 29, 2020

zerooverture Apr 29, 2020

iamkun Apr 30, 2020

zerooverture Apr 30, 2020 •

edited

Loading

iamkun Apr 30, 2020

zerooverture Apr 30, 2020 •

edited

Loading

iamkun commented May 14, 2020

feat:add plugin objectSupport #887

feat:add plugin objectSupport #887

Conversation

zerooverture commented Apr 27, 2020

codecov bot commented Apr 27, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamkun commented Apr 28, 2020

zerooverture commented Apr 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamkun Apr 29, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zerooverture Apr 30, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zerooverture Apr 30, 2020 • edited Loading

Choose a reason for hiding this comment

iamkun commented May 14, 2020

codecov bot commented Apr 27, 2020 •

edited

Loading

iamkun Apr 29, 2020 •

edited

Loading

zerooverture Apr 30, 2020 •

edited

Loading

zerooverture Apr 30, 2020 •

edited

Loading