Fix incorrect initializing country code by IP #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that initizalizeCountry() calls method getCountry() which mutates this.activeCountry and returns a promise and it doesn't wait for it (i.e. fire and forget). If inputOptions prop's showDialCode is true it ignores country code fetched by current IP
softerboy
force-pushed
the
master
branch
2 times, most recently
from
84ffa17
to
81b874d
Compare
|
@softerboy Thanks a lot for your help! Your changes included the other PR and there are changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that initizalizeCountry() calls method getCountry() which
mutates this.activeCountry and returns a promise and it doesn't wait for it (i.e. fire and forget).
If inputOptions prop's showDialCode is set to true it ignores country code fetched by current IP