Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to change dropdown width #311

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

DucNg
Copy link

@DucNg DucNg commented Dec 7, 2021

Changing dropdown size only using css was not easily achievable since vti__dropdown-list was placed inside vti__dropdown making width: 100% not working properly.

I figured out adding a "dropdown width" option would be a much easier and cleaner solution.

Is that okay with you?

@iamstevendao iamstevendao merged commit e52ef5c into iamstevendao:master Dec 8, 2021
@iamstevendao
Copy link
Owner

@DucNg Thanks for your help! it's available in v5.9.0

@DucNg DucNg deleted the dropdown-width branch December 8, 2021 09:01
@DucNg
Copy link
Author

DucNg commented Dec 8, 2021

Thank you so much!

@gnuletik
Copy link

For anyone upgrading: this PR is a breaking change if you have the dropdown-options prop already defined.
The default width value is only used if the prop is not defined. So, the dropdown width may break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants