fix: special chars in showSearchBox #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your help! |
andreasvoigt
pushed a commit
to andreasvoigt/vue-tel-input
that referenced
this pull request
Sep 26, 2023
(cherry picked from commit dd313a1)
andreasvoigt
pushed a commit
to andreasvoigt/vue-tel-input
that referenced
this pull request
Sep 26, 2023
(cherry picked from commit dd313a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you input special chars to showSearchBox, it throws an error as you can see in screenshot.
there is also an issue about this error: #402
With this pr, special characters are ignored and countries are listed according to the entered letter or number. I didnt use
\Wor[a-z0-9]regex because it won't work for non english languages like chinese, arabic, turkish etc.