Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent infinite loop in parsedMode calculation #463

Merged
merged 1 commit into from
May 9, 2024

Conversation

jdbacero
Copy link
Contributor

@jdbacero jdbacero commented May 8, 2024

Fix for #462 (and potentially #452)

Issue in version >9 where if prop mode set to auto would be unable to change/edit the phone number input after the phone number has been formatted due to a bug in a compute value of parsedMode that leads to an endless changing of value of the phoneObject which would then change the parsedMode return value, which would then change the value of phoneObject, etc etc.

The main culprit of this seems to be of how an if condition is being handled making parsedMode return the inappropriate value when result?.format(toUpperCase(parsedMode.value)) is being executed.

@iamstevendao
Copy link
Owner

thanks @jdbacero for your help!. just put here for visibility, it's a regression of #446
image

@iamstevendao iamstevendao merged commit e058acb into iamstevendao:main May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants