Mark generated attributes as safe #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for ratchet to work with Phoenix, generated attributes must be flagged as "raw". Otherwise they would be sanitized during rendering. This has the unfortunately effect of coupling ratchet to phoenix... I think we'll just be OK with this for now given that phoenix is probably its only use case. Eventually we'll need to provide some sort of hook that performs the special behavior in the presence of phoenix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for ratchet to work with Phoenix, generated attributes must be
flagged as "raw". Otherwise they would be sanitized during rendering.
This has the unfortunately effect of coupling ratchet to phoenix... I
think we'll just be OK with this for now given that phoenix is probably
its only use case. Eventually we'll need to provide some sort of hook
that performs the special behavior in the presence of phoenix.