[Feat] Exclude favicon from sitemaps

iamvishnusankar · Jul 1, 2023 · ba104ac · ba104ac
1 parent dd3a619
commit ba104ac
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/next-sitemap/src/utils/__tests__/url.test.ts b/packages/next-sitemap/src/utils/__tests__/url.test.ts
@@ -47,6 +47,7 @@ describe('next-sitemap/url', () => {
     expect(isNextInternalUrl('/about/_middleware')).toBeTruthy()
     expect(isNextInternalUrl('/some_url/about/_middleware')).toBeTruthy()
     expect(isNextInternalUrl('/projects/[id]/_middleware')).toBeTruthy()
+    expect(isNextInternalUrl('/favicon.ico')).toBeTruthy()
   })
 
   test('isNextInternalUrl: url params', () => {

diff --git a/packages/next-sitemap/src/utils/url.ts b/packages/next-sitemap/src/utils/url.ts
@@ -16,9 +16,9 @@ export const generateUrl = (baseUrl: string, slug: string): string => {
  * @param path path check
  */
 export const isNextInternalUrl = (path: string): boolean => {
-  return new RegExp(/[^/]*^.[_]|^\/(404|500)$|\/_middleware$|(?:\[)/g).test(
-    path
-  )
+  return new RegExp(
+    /[^/]*^.[_]|^\/(404|500)$|\/_middleware$|favicon.ico|(?:\[)/g
+  ).test(path)
 }
 
 /**