Change prints to logging #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies, haven't been checking github. |
|
I know things are a bit crazy at the moment! What do you think of moving the prints to logging? I think output should be suppressed, but we've still got easy access to it by simply setting the logging level to info for what we'd have printed now, or debug for all the detail. |
|
I think it's a great idea. Frankly I should have coded it that way to begin with. |
|
Any thoughts on getting this merged? |
|
Wow. I meant to merge this. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to suppress the print statement output for use in application. So this moves all prints to logging, either at debug or info level. I also updated the tests so that the information that was previously provided by print statements is still provided by the logger.