Add eslint and code fixes after formatting #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to DRAFT while waiting for #222 to be merged |
This was referenced Feb 13, 2024
Closed
changes obtained by applying the previous commit and running `npx prettier -w .`
massi-ang
force-pushed
the
chore_formatting_eslint_fixes
branch
from
03f590f
to
9ea49b9
Compare
|
Rebased onto |
ianarawjo
added a commit
that referenced
this pull request
Feb 24, 2024
* Add and run prettier * Add eslint and code fixes after formatting (#223) * chore(formatting): config files and packages * chore(formatting): package.json * chore(formatting): applying formatting changes obtained by applying the previous commit and running `npx prettier -w .` * chore(formatting): added formatting and linting to react app * chore(formatting): fixes * chore(eslint): apply fixes to utils.ts * rebuild --------- Co-authored-by: Massimiliano Angelino <angmas@amazon.com>
ianarawjo
added a commit
that referenced
this pull request
Feb 24, 2024
* Add and run prettier * Add eslint and code fixes after formatting (#223) * chore(formatting): config files and packages * chore(formatting): package.json * chore(formatting): applying formatting changes obtained by applying the previous commit and running `npx prettier -w .` * chore(formatting): added formatting and linting to react app * chore(formatting): fixes * chore(eslint): apply fixes to utils.ts * rebuild --------- Co-authored-by: Massimiliano Angelino <angmas@amazon.com> * Rebuild --------- Co-authored-by: Massimiliano Angelino <angmas@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #221, #174 together with PR #222
NOTE: Merge only after #222 has been merged to see the actual code changes
This PR completes the changes required to implement issue #221 by adding
esllint.Choices for linting configuration is to use the recommended rules from the respective plugins (react, typescript) with some general exception such as camelCase variable naming convention which is not being enforced. Also, props typing for React components has been disabled for the time being.
Refer to
chainfoge/react-server/.eslintrc.jsfor the current configuration.Linting is run both on
npm run buildandnpm run test.