Update specs to modern style guide #20

iancanderson · 2015-10-18T02:13:57Z

Prefer double quotes
Remove many before(:all) blocks
Change from "should" syntax to imperative mood
Remove rspec-its dependency

houndci-bot · 2015-10-18T02:14:01Z

spec/ingreedy_spec.rb

    end
  end
 end

 describe "with 'a' as quantity and preposition 'of'" do
-  before(:all) { @ingreedy = Ingreedy.parse "a dash of ginger" }
+  it "parses correctly" do
+    result = Ingreedy.parse "a dash of ginger" 


Trailing whitespace detected.

- Prefer double quotes - Remove many before(:all) blocks - Change from "should" syntax to imperative mood - Remove rspec-its dependency

houndci-bot reviewed Oct 18, 2015
View reviewed changes

Update specs to modern style guide

20f2349

- Prefer double quotes - Remove many before(:all) blocks - Change from "should" syntax to imperative mood - Remove rspec-its dependency

iancanderson force-pushed the modern-spec-style branch from 635ce35 to 20f2349 Compare October 18, 2015 02:27

iancanderson merged commit 20f2349 into master Oct 18, 2015

iancanderson deleted the modern-spec-style branch October 18, 2015 02:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update specs to modern style guide #20

Update specs to modern style guide #20

iancanderson commented Oct 18, 2015

houndci-bot Oct 18, 2015

Update specs to modern style guide #20

Update specs to modern style guide #20

Conversation

iancanderson commented Oct 18, 2015

houndci-bot Oct 18, 2015

Choose a reason for hiding this comment