Wrap Parslet exceptions #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Parslet exception is raised when attempting to parse invalid input. This means the consumer of the class needs to be concerned with the internal implementation of gem in order to rescue the failure. By wrapping the Parslet exception we can avoid leaking this information.
|
Great idea. Thanks @andyw8! |
|
I rebased this against master then merged in manually: 1eb5355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Parslet exception is raised when attempting to parse invalid input.
This means the consumer of the gem needs to be concerned with its
internal implementation in order to rescue the failure.
By wrapping the Parslet exception we can avoid leaking this information.