add support for UTF-8 [ready, waiting for review] #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
downcase, upcase is not working for letters like ę ("ę".upcase returns ę, it should return Ę)
houndci-bot
reviewed
Jun 7, 2017
| module Ingreedy | ||
| module CaseInsensitiveParser | ||
| def stri(str) | ||
| key_chars = str.split(//) | ||
| key_chars. | ||
| map! { |char| match["#{char.upcase}#{char.downcase}"] }. | ||
| map! { |char| match["#{Unicode.upcase(char)}#{Unicode.downcase(char)}"] }. |
| @@ -1,9 +1,11 @@ | |||
| require 'unicode' | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
There was a problem hiding this comment.
@iancanderson I would be happy to make proposed changes iff that project is revived (at this moment it seems that it is dead and changing PR style would be waste of time).
2 similar comments
|
Before that changes parslet was emitting massive amount of warnings, including complaints that It both silences warnings and fixes a potential bug with unrecognised capital accented letters. |
matkoniecz
changed the title
|
closing as this project is dead and abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downcase, upcase is not working for letters like ę ("ę".upcase returns ę, it should return Ę)
It is workaround for https://bugs.ruby-lang.org/issues/10085