Skip to content

Commit

Permalink
bump version to 1.0.1, bump rubocop version, fix rubocop issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Derek Tamsen committed Feb 2, 2016
1 parent c4380ac commit db32f1b
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 20 deletions.
9 changes: 0 additions & 9 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,6 @@ SelfAssignment:
SignalException:
Enabled: false

# Offense count: 53
# Cop supports --auto-correct.
SingleSpaceBeforeFirstArg:
Enabled: false

SpaceAroundOperators:
Enabled: false

Expand Down Expand Up @@ -304,10 +299,6 @@ Style/NumericLiterals:
Metrics/ParameterLists:
Enabled: false

Style/TrailingComma:
# EnforcedStyleForMultiline: comma
Enabled: false

Metrics/CyclomaticComplexity:
Enabled: false

Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ group :development, :test do
gem "rake", "~> 10.4"
gem "rspec", "~> 3.0"
gem "rspec-mocks", "~> 3.0"
gem "rubocop", "~> 0.24"
gem "rubocop", "~> 0.36"
gem "rubygems-tasks", "~> 0.2"
end
4 changes: 2 additions & 2 deletions lib/lowered/expectations.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
require 'pty'

class LoweredExpectations
VERSION = '1.0.0'
VERSION = '1.0.1'.freeze

class VersionPatternError < StandardError
end
Expand Down Expand Up @@ -54,7 +54,7 @@ def self.run!(*args, quiet: false)
while !r.eof?
c = r.getc
stdout << c
$stdout.write "#{c}"
$stdout.write c.to_s
end
Process.wait(pid)
end
Expand Down
2 changes: 1 addition & 1 deletion spec/integration/lowered/expectations_integration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

describe '.which' do
it 'returns true when the executable is on the PATH' do
expect(LoweredExpectations.which tool).to be_truthy
expect(LoweredExpectations.which(tool)).to be_truthy
end

it 'raises an error when the executable is not on the PATH' do
Expand Down
14 changes: 7 additions & 7 deletions spec/lowered/expectations_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

describe '.which' do
it 'returns true when the executable is on the PATH' do
expect(LoweredExpectations.which tool).to be_truthy
expect(LoweredExpectations.which(tool)).to be_truthy
end

it 'raises an error when the executable is not on the PATH' do
Expand All @@ -54,12 +54,12 @@

describe '.verify_version' do
it 'returns true when the version string matches the version pattern' do
expect(LoweredExpectations.verify_version version, '~> 0.1').to be_truthy
expect(LoweredExpectations.verify_version version, '~> 0').to be_truthy
expect(LoweredExpectations.verify_version version, '> 0.1.1').to be_truthy
expect(LoweredExpectations.verify_version version, '< 1').to be_truthy
expect(LoweredExpectations.verify_version version, '> 0').to be_truthy
expect(LoweredExpectations.verify_version version, "= #{version}").to be_truthy
expect(LoweredExpectations.verify_version(version, '~> 0.1')).to be_truthy
expect(LoweredExpectations.verify_version(version, '~> 0')).to be_truthy
expect(LoweredExpectations.verify_version(version, '> 0.1.1')).to be_truthy
expect(LoweredExpectations.verify_version(version, '< 1')).to be_truthy
expect(LoweredExpectations.verify_version(version, '> 0')).to be_truthy
expect(LoweredExpectations.verify_version(version, "= #{version}")).to be_truthy
end

it 'raise an error when the version string does not match the version pattern' do
Expand Down

0 comments on commit db32f1b

Please sign in to comment.