Add no metallicity PHOENIX grid interface #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exigence for this is that I think many people will not want to fit metallicity because it allows having a smaller subset of the PHOENIX catalog downloaded and subsequently simplifies any further fitting by one whole parameter. In addition, for a lot of stars that I study with IRTF we expect solar metallicity and will happily save computation time over rigor for this parameter. This is not necessarily a thorough pull request but it is simple and can let people who are using the grid_tools separately from the rest of Starfish have a little bit more flexibility right out of the box.
|
Thanks for the extra functionality! |
mileslucas
pushed a commit
that referenced
this pull request
Dec 18, 2018
Add no metallicity PHOENIX grid interface
mileslucas
pushed a commit
that referenced
this pull request
Dec 18, 2018
Add no metallicity PHOENIX grid interface
mileslucas
pushed a commit
that referenced
this pull request
Dec 18, 2018
Add no metallicity PHOENIX grid interface
jason-neal
pushed a commit
to jason-neal/Starfish
that referenced
this pull request
Jan 2, 2019
Add no metallicity PHOENIX grid interface
mileslucas
pushed a commit
that referenced
this pull request
May 16, 2019
Add no metallicity PHOENIX grid interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exigence for this is that I think many people will not want to fit metallicity because it allows having a smaller subset of the PHOENIX catalog downloaded and subsequently simplifies any further fitting by one whole parameter. In addition, for a lot of stars that I study with IRTF we expect solar metallicity and will happily save computation time over rigor for this parameter. This is not necessarily a thorough pull request but it is simple and can let people who are using the grid_tools separately from the rest of Starfish have a little bit more flexibility right out of the box.