Instrument postgresql simple #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Obviously this isn't done yet, but is it moving in a usable direction, @iand675 ? |
magthe
force-pushed
the
instrument-postgresql-simple
branch
2 times, most recently
from
fd0e412
to
65898ad
Compare
|
Finally got around to finish it up so it's ready for review. |
magthe
force-pushed
the
instrument-postgresql-simple
branch
from
65898ad
to
3028a4a
Compare
iand675
reviewed
Jan 16, 2023
instrumentation/postgresql-simple/src/OpenTelemetry/Instrumentation/PostgresqlSimple.hs
Outdated
Show resolved
Hide resolved
instrumentation/postgresql-simple/src/OpenTelemetry/Instrumentation/PostgresqlSimple.hs
Outdated
Show resolved
Hide resolved
|
Thanks for pushing this along! Really excited to land this. |
magthe
force-pushed
the
instrument-postgresql-simple
branch
2 times, most recently
from
974c1c3
to
9ab228e
Compare
|
Hopefully this addresses all issues. |
kakkun61
requested changes
Apr 11, 2023
| @@ -39,6 +39,7 @@ library | |||
| , postgresql-libpq | |||
| , postgresql-simple | |||
| , text | |||
| , unliftio-core | |||
There was a problem hiding this comment.
@magthe please edit package.yaml instead of this.
There was a problem hiding this comment.
I'm hoping the change I pushed addresses this.
magthe
force-pushed
the
instrument-postgresql-simple
branch
from
9ab228e
to
46729f5
Compare
|
Ping! |
|
This has lingered for a while now. Will it be merged if I resolve the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing this early to get feedback and suggestions.
Attempt to address #7.