Set exception details when using WAI and Yesod instrumentation together #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the WAI instrumentation is used (so there is a span on the request), this instrumentation only sets the shared attributes. Since exceptions never reach WAI when used with Yesod (since they're caught to error pages), this means that error traces don't include any details. By calling `recordException` and `setStatus` here, we can address that. Fixes iand675#102
pbrisbin
changed the title
|
Regarding the pre-commit hook... When I run foumolu (the version in the in-use resolver), I get a configuration error: % stack install --copy-compiler-tool fourmolu
Copying from
/home/patrick/.stack/snapshots/x86_64-linux-tinfo6/a76d5db647918a4cbcac406bf469be85d6333b9d6435f4dc08f2e0708720d750/9.2.7/bin/fourmolu
to /home/patrick/.stack/compiler-tools/x86_64-linux-tinfo6/ghc-9.2.7/bin/fourmolu.
Copied executables to /home/patrick/.stack/compiler-tools/x86_64-linux-tinfo6/ghc-9.2.7/bin/:
* fourmolu
% stack exec -- fourmolu --version
fourmolu 0.9.0.0 UNKNOWN UNKNOWN
using ghc-lib-parser 9.2.7.20230228
% stack exec -- fourmolu -i .
Failed to load /home/patrick/code/freckle/hs-opentelemetry/fourmolu.yaml:
Aeson exception:
Error in $['in-style']: unknown value: "no-space"
Valid values are: "left-align" or "right-align"
% 255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address warnings and HLint
23743a3
Extract isInternalError
0d9cc2e
Set exception details when using WAI and Yesod instrumentation together
9610e0f
When the WAI instrumentation is used (so there is a span on the
request), this instrumentation only sets the shared attributes. Since
exceptions never reach WAI when used with Yesod (since they're caught to
error pages), this means that error traces don't include any details. By
calling
recordExceptionandsetStatushere, we can address that.Fixes #102