bugfix: Batch processor did not shut down cleanly, losing metrics #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the process exited, the sending of metrics to OTLP was rudely interrupted by `cancel`. This meant that the root span would often go missing if you instrumented some kind of command line application with the root span created at process creation. This patch changes the shutdown logic to first ask the exporter to send what it has and shut down, then forcibly kill it if that takes too long.
lf-
force-pushed
the
batch-processor-shutdown
branch
from
baf6fe3
to
9d6dba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the process exited, the sending of metrics to OTLP was rudely
interrupted by
cancel. This meant that the root span would often gomissing if you instrumented some kind of command line application with
the root span created at process creation.
This patch changes the shutdown logic to first ask the exporter to send
what it has and shut down, then forcibly kill it if that takes too long.