dotenv for examples #54
Conversation
.github/workflows/haskell.yml
Outdated
| @@ -12,6 +12,9 @@ jobs: | |||
| - uses: haskell/actions/setup@v2 | |||
| with: | |||
| enable-stack: true | |||
| - if: ${{ runner.os == 'Linux' }} | |||
There was a problem hiding this comment.
Are we able to drop the changes to this file?
There was a problem hiding this comment.
actions/runner-images#7061 seems already been solved. Right!
.env
Outdated
| @@ -1 +1,2 @@ | |||
| PATH="./scripts:$PATH" | |||
| # examples | |||
| OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4318 | |||
There was a problem hiding this comment.
I'd rather that this .env file was scoped to the examples that use it. I think in the future we'll want to have examples for exporting to different 3rd party providers like datadog, so we'd need different env var values in those cases.
There was a problem hiding this comment.
On such cases, we will have OTEL_EXPORTER_XXX_ENDPOINTs additionally?
Does OTEL_EXPORTER_OTLP_ENDPOINT existence make library use otlp protocol?
There was a problem hiding this comment.
I think for the different examples, we would generally need different OTEL_EXPORTER_OTLP_ENDPOINT values. I don't think there are other standardized OTEL_EXPORTER_XXX_ENDPOINT values currently.
| @@ -1,3 +1,4 @@ | |||
| use_nix | |||
| PATH_add "./scripts" | |||
Add env vars for examples