Testsfix #425
Merged
Testsfix #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Response formats aren't the same as what new requests is expecting, or something like that
After re-running the cassettes had to update some expectations to match the newly pulled data
Might as well add it in while I'm fixing these things
Match what I'm running locally
pyvcr requires 3.10 now and I don't feel like figuring out how to support older versions
Shuts ruff up
This is just testing that a function wrapped in the class does the same thing as the unwrapped a) that's silly b) I'm testing way too much stuff for one test and I don't feel like refactoring it since the premise is dumb c) When it fails it creates side effects that fail other tests
ianepreston
added a commit
that referenced
this pull request
Jun 27, 2024
* test against python 3.12 * update cassettes Response formats aren't the same as what new requests is expecting, or something like that * Update tests After re-running the cassettes had to update some expectations to match the newly pulled data * expand testing to 3.12 Might as well add it in while I'm fixing these things * Drop 3.12 Tables doesn't seem to support it. Getting near the point where I have to rebuild this library without the stupid HDFS dependency * bump poetry and nox versions Match what I'm running locally * version updates * Drop support for 3.9 and 3.8 pyvcr requires 3.10 now and I don't feel like figuring out how to support older versions * explicitly import scwds Shuts ruff up * remove static methods check This is just testing that a function wrapped in the class does the same thing as the unwrapped a) that's silly b) I'm testing way too much stuff for one test and I don't feel like refactoring it since the premise is dumb c) When it fails it creates side effects that fail other tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to rebuild my cassettes recording network outputs and adjust some expectations