Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Huge numbers for dice #472

Merged
merged 150 commits into from Mar 29, 2024
Merged

Huge numbers for dice #472

merged 150 commits into from Mar 29, 2024

Conversation

ianfhunter
Copy link
Owner

@ianfhunter ianfhunter commented Mar 23, 2024 •
edited

Description

⬆️ Increase size of dice allowed by: 1d2147483647 ->1d9223372036854775807
🦺 Start to catch over/underflow issues

How Has This Been Tested

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Test Coverage (Additional test(s) without any extra code)
  • Documentation Improvements
  • Code Quality / Maintenance

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation & I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I give my permission for my code to be used in this project under this license and any future license terms

ianfhunter and others added 8 commits March 23, 2024 16:56
@ianfhunter
Create test_huge_number.py
b91775b 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
1c40395 
This commit fixes the style issues introduced in b91775b according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #472
@ianfhunter
Update test_huge_number.py
bf8f6a3 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
00f5d52 
This commit fixes the style issues introduced in bf8f6a3 according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #472
@ianfhunter
Update test_huge_number.py
1e98e80 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update safe_functions.c
6179d56 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update safe_functions.h
353001e 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update dice.lex
f2e7ee9 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@github-actions github-actions bot added the core label Mar 23, 2024
@ianfhunter
Update vec.h
bdc0e46 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update roll_parameters.h
c6d3868 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update dice.yacc
2b4f24f 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update vec.h
ca7b44d 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update vector_functions.h
3320da3 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update vector_functions.c
c82c3f9 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update string_functions.h
7cb3198 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update vector_functions.h
560ff7e 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update string_functions.c
2a9daf2 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update vector_functions.c
2f22806 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update safe_functions.h
846b89a 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update safe_functions.c
d667b76 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update mocking.h
6fcacc5 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update mocking.c
f4248c4 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update array_functions.h
5c9ab89 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update array_functions.c
1543210 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update randomness.c
d569924 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update randomness.h
7d365c2 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update dice_frontend.c
38ceadd 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update dice_core.h
dfedd32 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update dice_core.c
fb730e7 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
deepsource-autofix bot and others added 6 commits March 29, 2024 10:59
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
c556243 
This commit fixes the style issues introduced in 7365bee according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #472
@ianfhunter
Update __init__.py
346fe6d 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
8750e53 
This commit fixes the style issues introduced in 346fe6d according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #472
@ianfhunter
Update test_huge_number.py
1dfac7c 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update test_huge_number.py
c5652e6 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update dice.yacc
0af9d2a 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update src/grammar/rolls/dice_core.c
f32a672 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
ianfhunter and others added 15 commits March 29, 2024 11:15
@ianfhunter
Update src/grammar/rolls/dice_core.c
47377fa 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update test_huge_number.py
85e22cf 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
b74e406 
This commit fixes the style issues introduced in 85e22cf according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #472
@ianfhunter
Update test_huge_number.py
ae1a203 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update __init__.py
598b67c 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
5374fdf 
This commit fixes the style issues introduced in 598b67c according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #472
@ianfhunter
Update randomness.c
55d587c 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update randomness.c
2087d46 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update randomness.h
c9a0928 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update randomness.c
21f325b 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update randomness.c
3059908 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update randomness.h
dd09dd5 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update randomness.c
75de539 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update randomness.h
9e5addb 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@ianfhunter
Update test_huge_number.py
e086cf1 
Signed-off-by: Ian Hunter <ianfhunter@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ianfhunter ianfhunter changed the title [WIP] Huge numbers Huge numbers for dice Mar 29, 2024
@ianfhunter ianfhunter merged commit b5949f1 into main Mar 29, 2024
37 checks passed
@ianfhunter ianfhunter deleted the huge_numbers branch March 29, 2024 12:47
ianfhunter added a commit that referenced this pull request Mar 30, 2024
@ianfhunter
Revert "[WIP] Huge numbers (#472)"
6d61ee6 
This reverts commit b5949f1.
@ianfhunter ianfhunter mentioned this pull request Mar 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core java JavaScript Perl Python R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ianfhunter