Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default output to github on GitHub Actions #1464

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Feb 21, 2024

Description:

Default the --output flag to github when GITHUB_ACTIONS is true for ease of use on GitHub Actions.

Related Issues:

Fixes #1459

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

Default the `--output` flag to `github` when `GITHUB_ACTIONS` is `true`.

Fixes #1459

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis linked an issue Feb 21, 2024 that may be closed by this pull request
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7018702) 79.04% compared to head (ccf2f7f) 79.16%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1464      +/-   ##
==========================================
+ Coverage   79.04%   79.16%   +0.11%     
==========================================
  Files          15       15              
  Lines         902      907       +5     
==========================================
+ Hits          713      718       +5     
  Misses        138      138              
  Partials       51       51              
Files Coverage Δ
internal/cmd/todos/app.go 85.77% <100.00%> (+0.33%) ⬆️

@ianlewis ianlewis merged commit 95753d7 into main Feb 21, 2024
15 checks passed
@ianlewis ianlewis deleted the 1459-bug-use-github-actions-output-by-default-when-github_actions=true branch February 21, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Use GitHub Actions output by default when GITHUB_ACTIONS=true
1 participant