fix: exclude-dir not matching with path separator #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--exclude-dir` now ignores trailing path separators on the directory name passed to it. This is since it's natural to pass something like `mydir/` as a directory name. Fixes #1463 Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
=======================================
Coverage 79.16% 79.16%
=======================================
Files 15 15
Lines 907 907
=======================================
Hits 718 718
Misses 138 138
Partials 51 51
|
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
…ory-with-at-the-end Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
ianlewis
deleted the
1463-bug-exclude-dir-does-not-exclude-directory-with-at-the-end
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
--exclude-dirnow ignores trailing path separators on the directory name passed to it. This is since it's natural to pass something likemydir/as a directory name.Related Issues:
Fixes #1463
Checklist: