Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --charset flag #436

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Conversation

ianlewis
Copy link
Owner

Fixes #415

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis linked an issue Aug 28, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #436 (feac2ba) into main (295aee9) will decrease coverage by 0.38%.
The diff coverage is 64.86%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   79.94%   79.57%   -0.38%     
==========================================
  Files          19       19              
  Lines        1047     1072      +25     
  Branches       14       14              
==========================================
+ Hits          837      853      +16     
- Misses        151      157       +6     
- Partials       59       62       +3     
Files Changed Coverage Δ
internal/cmd/todos/app.go 82.19% <62.50%> (-2.84%) ⬇️
internal/scanner/scanner.go 76.55% <66.66%> (+0.08%) ⬆️
internal/walker/walker.go 60.36% <100.00%> (ø)

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis merged commit 6700789 into main Aug 28, 2023
26 checks passed
@ianlewis ianlewis deleted the 415-make-encoding-detection-optional branch August 28, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make encoding detection optional
1 participant