Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate NULLS FIRST and NULLS LAST in ORDER BY clause #12

Closed
ianmcook opened this issue Sep 4, 2019 · 0 comments
Closed

Translate NULLS FIRST and NULLS LAST in ORDER BY clause #12

ianmcook opened this issue Sep 4, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@ianmcook
Copy link
Owner

ianmcook commented Sep 4, 2019

Currently queryparser will throw an error if the NULLS FIRST or NULLS LAST keywords are used in the ORDER BY clause. A future version of queryparser should recognize and parse these keywords and modify the order_by sublist accordingly. For example, the clause ORDER BY x NULLS FIRST would be translated as follows:

$order_by
$order_by[[1]]
is.na(x)

$order_by[[2]]
x
@ianmcook ianmcook added the enhancement New feature or request label Sep 4, 2019
ianmcook pushed a commit that referenced this issue Feb 5, 2020
Update NEWS.md (#12, #24)
0be2512
ianmcook pushed a commit that referenced this issue Feb 5, 2020
Do not use dplyr::desc() or -xtfrm() inside is.na() (#12, #24)
6a2e8e3
ianmcook pushed a commit that referenced this issue Feb 5, 2020
Add tests of ASC/DESC with NULLS FIRST/LAST (#12, #24)
03f25d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianmcook