Skip to content

/ queryparser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use && and || in translated expressions #2

Closed
ianmcook opened this issue Aug 31, 2019 · 1 comment
Closed

Do not use && and || in translated expressions #2

ianmcook opened this issue Aug 31, 2019 · 1 comment
Labels
bug

Comments

@ianmcook
Copy link
Owner

@ianmcook ianmcook commented Aug 31, 2019

The operators && and || are not vectorized in R so should not be used in expressions that will be applied in a vectorized fashion to data frames. Translate AND and OR to & and | instead. Consider adding a note and example to the README describing how these operators do not short circuit like SQL's AND and OR sometimes do.
ianmcook added a commit that referenced this issue Aug 31, 2019
@ianmcook
Do not use && and || in translated R expressions (#2)
35fba0f
@ianmcook
Copy link
Owner Author

@ianmcook ianmcook commented Aug 31, 2019

Fixed in 35fba0f
@ianmcook ianmcook closed this Aug 31, 2019
@ianmcook ianmcook added the bug label Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@ianmcook
You can’t perform that action at this time.