- Rename $this->admin to $this->user in every feature test

- Temporary disable email verification feature test
ianriizky · Feb 12, 2022 · 1b9f038 · 1b9f038
1 parent c7c73f6
commit 1b9f038
Show file tree

Hide file tree

Showing 6 changed files with 50 additions and 52 deletions.
diff --git a/tests/Feature/Auth/EmailVerificationTest.php b/tests/Feature/Auth/EmailVerificationTest.php
@@ -24,43 +24,41 @@ class EmailVerificationTest extends TestCase
     //     $response->assertOk();
     // }
 
-    public function test_email_can_be_verified()
-    {
-        /** @var \App\Models\User $user */
-        $user = User::factory()->forBranch()->create([
-            'email_verified_at' => null,
-        ]);
+    // public function test_email_can_be_verified()
+    // {
+    //     /** @var \App\Models\User $user */
+    //     $user = User::factory()->unverified()->forBranch()->create();
 
-        Event::fake();
+    //     Event::fake();
 
-        $verificationUrl = URL::temporarySignedRoute(
-            'verification.verify',
-            Carbon::now()->addMinutes(60),
-            ['id' => $user->getKey(), 'hash' => sha1($user->getEmailForVerification())]
-        );
+    //     $verificationUrl = URL::temporarySignedRoute(
+    //         'verification.verify',
+    //         Carbon::now()->addMinutes(60),
+    //         ['id' => $user->getKey(), 'hash' => sha1($user->getEmailForVerification())]
+    //     );
 
-        $response = $this->actingAs($user)->get($verificationUrl);
+    //     $response = $this->actingAs($user)->get($verificationUrl);
 
-        Event::assertDispatched(Verified::class);
-        $this->assertTrue($user->fresh()->hasVerifiedEmail());
-        $response->assertRedirect(RouteServiceProvider::HOME.'?verified=1');
-    }
+    //     Event::assertDispatched(Verified::class);
+    //     $this->assertTrue($user->fresh()->hasVerifiedEmail());
+    //     $response->assertRedirect(RouteServiceProvider::HOME.'?verified=1');
+    // }
 
-    public function test_email_is_not_verified_with_invalid_hash()
-    {
-        /** @var \App\Models\User $user */
-        $user = User::factory()->forBranch()->create([
-            'email_verified_at' => null,
-        ]);
+    // public function test_email_is_not_verified_with_invalid_hash()
+    // {
+    //     /** @var \App\Models\User $user */
+    //     $user = User::factory()->forBranch()->create([
+    //         'email_verified_at' => null,
+    //     ]);
 
-        $verificationUrl = URL::temporarySignedRoute(
-            'verification.verify',
-            Carbon::now()->addMinutes(60),
-            ['id' => $user->getKey(), 'hash' => sha1('wrong-email')]
-        );
+    //     $verificationUrl = URL::temporarySignedRoute(
+    //         'verification.verify',
+    //         Carbon::now()->addMinutes(60),
+    //         ['id' => $user->getKey(), 'hash' => sha1('wrong-email')]
+    //     );
 
-        $this->actingAs($user)->get($verificationUrl);
+    //     $this->actingAs($user)->get($verificationUrl);
 
-        $this->assertFalse($user->fresh()->hasVerifiedEmail());
-    }
+    //     $this->assertFalse($user->fresh()->hasVerifiedEmail());
+    // }
 }
diff --git a/tests/Feature/Auth/RegistrationTest.php b/tests/Feature/Auth/RegistrationTest.php
@@ -25,7 +25,7 @@ public function test_new_users_can_register()
         Event::fake();
 
         $response = $this->post(route('register'), [
-            'branch_id' => Branch::value('id'),
+            'branch_id' => Branch::inRandomOrder()->value('id'),
 
             'username' => $user->username,
             'name' => $user->name,

diff --git a/tests/Feature/DashboardTest.php b/tests/Feature/DashboardTest.php
@@ -3,11 +3,11 @@
 use function Pest\Laravel\actingAs;
 
 beforeEach(function () {
-    $this->admin = pest_create_random_user();
+    $this->user = pest_create_random_user();
 });
 
 it('has dashboard page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('dashboard'))
         ->assertOk();
 });
diff --git a/tests/Feature/EducationTest.php b/tests/Feature/EducationTest.php
@@ -3,61 +3,61 @@
 use function Pest\Laravel\actingAs;
 
 beforeEach(function () {
-    $this->admin = pest_create_random_user();
+    $this->user = pest_create_random_user();
 });
 
 it('has education index page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('education.index'))
         ->assertOk();
 });
 
 #region webinar-literasi-keuangan
 it('has education webinar-literasi-keuangan index page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('education.webinar-literasi-keuangan.index'))
         ->assertOk();
 });
 
 it('has education webinar-literasi-keuangan template-surat-penawaran-webinar page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('education.webinar-literasi-keuangan.template-surat-penawaran-webinar'))
         ->assertOk();
 });
 
 it('has education webinar-literasi-keuangan template-presentasi-webinar-literasi-keuangan page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('education.webinar-literasi-keuangan.template-presentasi-webinar-literasi-keuangan'))
         ->assertOk();
 });
 
 it('has education webinar-literasi-keuangan template-rundown-webinar-literasi-keuangan page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('education.webinar-literasi-keuangan.template-rundown-webinar-literasi-keuangan'))
         ->assertOk();
 });
 
 it('has education webinar-literasi-keuangan pemetaan-sekolah-kampus-potensi-webinar page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('education.webinar-literasi-keuangan.pemetaan-sekolah-kampus-potensi-webinar'))
         ->assertOk();
 });
 
 it('has education webinar-literasi-keuangan input-rencana-penyelenggaraan-webinar page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('education.webinar-literasi-keuangan.input-rencana-penyelenggaraan-webinar'))
         ->assertOk();
 });
 #endregion webinar-literasi-keuangan
 
 it('has education pembukaan-rekening-online page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('education.pembukaan-rekening-online'))
         ->assertOk();
 });
 
 it('has education employee-get-cin page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('education.employee-get-cin'))
         ->assertOk();
 });
diff --git a/tests/Feature/ProfileTest.php b/tests/Feature/ProfileTest.php
@@ -7,19 +7,19 @@
 use function Pest\Laravel\assertDatabaseHas;
 
 beforeEach(function () {
-    $this->admin = pest_create_random_user();
+    $this->user = pest_create_random_user();
 });
 
 it('has profile edit page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('profile.edit'))
         ->assertOk();
 });
 
 it('can update profile', function () {
     $data = Arr::except(User::factory()->rawForm(), 'role');
 
-    actingAs($this->admin)
+    actingAs($this->user)
         ->put(route('profile.edit'), $data)
         ->assertRedirect(route('profile.edit'));
 

diff --git a/tests/Feature/ReportTest.php b/tests/Feature/ReportTest.php
@@ -3,29 +3,29 @@
 use function Pest\Laravel\actingAs;
 
 beforeEach(function () {
-    $this->user = pest_create_manager_from_existed_branch();
+    $this->user = pest_create_random_user();
 });
 
 it('has report index page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('report.index'))
         ->assertOk();
 });
 
 it('has report laporan-pencapaian-new-cin index page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('report.laporan-pencapaian-new-cin.index'))
         ->assertOk();
 });
 
 it('has report dashboard-growth-new-cin index page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('report.dashboard-growth-new-cin.index'))
         ->assertOk();
 });
 
 it('has report dashboard-penutupan-cin index page', function () {
-    actingAs($this->admin)
+    actingAs($this->user)
         ->get(route('report.dashboard-penutupan-cin.index'))
         ->assertOk();
 });