Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert example scenarios into full end-to-end tests and add GitHub workflows CI #66

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Convert example scenarios into full end-to-end tests and add GitHub workflows CI #66

merged 5 commits into from
Dec 13, 2021

Conversation

iansan5653
Copy link
Owner

  • Convert example scenarios into end-to-end tests that run with pytest and compare output to expected files
  • Add support for a new --disable-timestamp CLI argument that will remove the timestamp from output files and folders. This is useful for automated flows where the file name needs to be known.
  • Fix handling of quoted CLI arguments (fixes Command line arguments don't support quoted file paths #65).
  • Add CI configuration to run pytest on push and PR

@iansan5653
Rearrange example files to work as e2e tests
e9fb4e9
@iansan5653
Change example scenarios into end-to-end tests
0bd48e3 
Move examples to /test/end-to-end, rename the example folders, add
expected output files, add pytest test runner and configuration.
@iansan5653
Add support for --disable-timestamp CLI argument
c5165d3 
This will disable timestamps in the output file/folder names. Useful for
obtaining consistent filenames but comes at the risk of overwriting
files from previous runs.
@iansan5653
Fix handling of quoted CLI paths
6ecaeac 
Fixes handling of double-quotes paths in CLI arguments by stripping
quotes from the argument if present. Adds two new utility methods to
assist with this: str_utils.strip_double_quotes and
file_handling.parse_path_arg.

Fixes #65
@iansan5653
Add CI configuration to run Pytest
abc48df
@iansan5653 iansan5653 self-assigned this Dec 13, 2021
@iansan5653 iansan5653 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Dec 13, 2021
@iansan5653 iansan5653 merged commit 7ab7ec6 into master Dec 13, 2021
@iansan5653 iansan5653 deleted the tests/convert-examples-to-tests branch December 13, 2021 01:50
@iansan5653 iansan5653 linked an issue Dec 13, 2021 that may be closed by this pull request
Convert examples to end-to-end snapshot-style tests #64
Closed
@iansan5653 iansan5653 mentioned this pull request Dec 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iansan5653 iansan5653

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command line arguments don't support quoted file paths Convert examples to end-to-end snapshot-style tests
1 participant
@iansan5653