Merge pull request nrkno#231 from tv2/SOF-1410/moveMigrationAwayFromX…

…_X_X SOF-1410 Move migrations away from X_X_X file
ianshade · Apr 3, 2023 · 4274b1c · 4274b1c
2 parents e531394 + 927808a
commit 4274b1c
Show file tree

Hide file tree

Showing 4 changed files with 78 additions and 66 deletions.
diff --git a/meteor/server/migration/46_1.ts b/meteor/server/migration/46_1.ts
@@ -0,0 +1,68 @@
+import { addMigrationSteps } from './databaseMigration'
+import { ShowStyleVariant, ShowStyleVariants } from '../../lib/collections/ShowStyleVariants'
+import { PieceInstances } from '../../lib/collections/PieceInstances'
+import { TriggeredActions } from '../../lib/collections/TriggeredActions'
+
+export const addSteps = addMigrationSteps('46.1.0', [
+	{
+		id: 'Add missing ranks to ShowStyleVariants',
+		canBeRunAutomatically: true,
+		validate: () => {
+			return (
+				ShowStyleVariants.find({
+					_rank: { $exists: false },
+				}).count() > 0
+			)
+		},
+		migrate: () => {
+			ShowStyleVariants.find({
+				_rank: { $exists: false },
+			}).forEach((variant: ShowStyleVariant, index: number) => {
+				ShowStyleVariants.upsert(variant._id, {
+					$set: {
+						_rank: index,
+					},
+				})
+			})
+		},
+	},
+	{
+		id: 'Change PieceInstances.dynamicallyInserted type',
+		canBeRunAutomatically: true,
+		validate: () => {
+			return (
+				PieceInstances.find({
+					dynamicallyInserted: { $type: 'number' },
+				}).count() > 0
+			)
+		},
+		migrate: () => {
+			PieceInstances.find({
+				dynamicallyInserted: { $type: 'number' },
+			}).forEach((pieceInstance) => {
+				if (typeof pieceInstance.dynamicallyInserted !== 'number') {
+					return
+				}
+				PieceInstances.update(pieceInstance._id, {
+					$set: { dynamicallyInserted: { time: pieceInstance.dynamicallyInserted } },
+				})
+			})
+		},
+	},
+	{
+		id: 'Add "useNameForDisplay" attribute to TriggeredActions',
+		canBeRunAutomatically: true,
+		validate: () => {
+			return (
+				TriggeredActions.find({
+					useNameForDisplay: { $exists: false },
+				}).count() > 0
+			)
+		},
+		migrate: () => {
+			TriggeredActions.find({}).forEach((action) => {
+				TriggeredActions.update(action._id, { $set: { useNameForDisplay: false } })
+			})
+		},
+	},
+])
diff --git a/meteor/server/migration/46_2.ts b/meteor/server/migration/46_2.ts
@@ -0,0 +1,4 @@
+import { addMigrationSteps } from './databaseMigration'
+import { createMigrationsForAddingMissingIdsInSelectFromColumnEntries } from './addMissingIdsForSelectFromColumns'
+
+export const addSteps = addMigrationSteps('46.2.1', [...createMigrationsForAddingMissingIdsInSelectFromColumnEntries()])
diff --git a/meteor/server/migration/X_X_X.ts b/meteor/server/migration/X_X_X.ts
@@ -1,9 +1,5 @@
 import { addMigrationSteps } from './databaseMigration'
 import { CURRENT_SYSTEM_VERSION } from './currentSystemVersion'
-import { ShowStyleVariant, ShowStyleVariants } from '../../lib/collections/ShowStyleVariants'
-import { PieceInstances } from '../../lib/collections/PieceInstances'
-import { TriggeredActions } from '../../lib/collections/TriggeredActions'
-import { createMigrationsForAddingMissingIdsInSelectFromColumnEntries } from './addMissingIdsForSelectFromColumns'
 
 /*
  * **************************************************************************************
@@ -17,66 +13,4 @@ import { createMigrationsForAddingMissingIdsInSelectFromColumnEntries } from './
 
 export const addSteps = addMigrationSteps(CURRENT_SYSTEM_VERSION, [
 	// Add some migrations!
-	{
-		id: 'Add missing ranks to ShowStyleVariants',
-		canBeRunAutomatically: true,
-		validate: () => {
-			return (
-				ShowStyleVariants.find({
-					_rank: { $exists: false },
-				}).count() > 0
-			)
-		},
-		migrate: () => {
-			ShowStyleVariants.find({
-				_rank: { $exists: false },
-			}).forEach((variant: ShowStyleVariant, index: number) => {
-				ShowStyleVariants.upsert(variant._id, {
-					$set: {
-						_rank: index,
-					},
-				})
-			})
-		},
-	},
-	{
-		id: 'Change PieceInstances.dynamicallyInserted type',
-		canBeRunAutomatically: true,
-		validate: () => {
-			return (
-				PieceInstances.find({
-					dynamicallyInserted: { $type: 'number' },
-				}).count() > 0
-			)
-		},
-		migrate: () => {
-			PieceInstances.find({
-				dynamicallyInserted: { $type: 'number' },
-			}).forEach((pieceInstance) => {
-				if (typeof pieceInstance.dynamicallyInserted !== 'number') {
-					return
-				}
-				PieceInstances.update(pieceInstance._id, {
-					$set: { dynamicallyInserted: { time: pieceInstance.dynamicallyInserted } },
-				})
-			})
-		},
-	},
-	{
-		id: 'Add "useNameForDisplay" attribute to TriggeredActions',
-		canBeRunAutomatically: true,
-		validate: () => {
-			return (
-				TriggeredActions.find({
-					useNameForDisplay: { $exists: false },
-				}).count() > 0
-			)
-		},
-		migrate: () => {
-			TriggeredActions.find({}).forEach((action) => {
-				TriggeredActions.update(action._id, { $set: { useNameForDisplay: false } })
-			})
-		},
-	},
-	...createMigrationsForAddingMissingIdsInSelectFromColumnEntries(),
 ])
diff --git a/meteor/server/migration/migrations.ts b/meteor/server/migration/migrations.ts
@@ -53,6 +53,12 @@ addSteps1_44_0()
 import { addSteps as addSteps1_46_0 } from './1_46_0'
 addSteps1_46_0()
 
+import { addSteps as addSteps46_1 } from './46_1'
+addSteps46_1()
+
+import { addSteps as addSteps46_2 } from './46_2'
+addSteps46_2()
+
 // Migrations for the in-development release:
 import { addSteps as addStepsX_X_X } from './X_X_X'
 addStepsX_X_X()