Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redux support and implement small example #9

Closed
wants to merge 7 commits into from

Conversation

scherler
Copy link
Contributor

The PR contains a complete working version with a redux store and static html export. The last was a bit tricky but in the end I found a way to workaround the invocation of the store/provider.

redux state is created using Immutable and further hooked up https://github.com/zalmoxisus/redux-devtools-extension for dev experience.

@iansinnott
Copy link
Owner

Thanks for the PR @scherler. It would be nice to be able to have Redux out of the box, I really like Redux as well, but not everyone is using Redux. Since this is a boilerplate I'd like to avoid adding any frameworks to it other than React itself.

But it would be great to be able to add redux very easily. Maybe a separate branch? Maybe a yeoman generator?

I'm definitely open to suggestions but I'd like to avoid adding Redux as a hard dependency to master.

@scherler
Copy link
Contributor Author

Yeah, I understand what you mean, maybe in the spirit of #5 but I must admit I am not sure how to do that ATM. The main problem is that you have to wrap the App component with the redux store to inject it in the App as global meaning one would need to do the "wiring" outside of the app in the dependency but still it would need to be sufficient extensible for the user to add their logic. as said I have to think about it.

You can merge the PR into a branch if you want, I am not sure how I can open a PR against a new branch of your rep.

@iansinnott
Copy link
Owner

OK, I'll close this PR for now but it can server as a reference to anyone else who wants to integrate with Redux. I'll add a note to the readme. Thanks @scherler

@iansinnott iansinnott closed this May 26, 2016
@iansinnott iansinnott mentioned this pull request May 27, 2016
@bdougie
Copy link

bdougie commented Jun 2, 2016

+1 For not merging this, but referencing to it instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants