Fixed triple click workaround breaking void elements selection (#5451)

* Fixed tripple click workaround breaking void selection * Add changesets * Fix ts error * Make code style more consistent
ianstormtaylor · Jun 16, 2023 · 12ff246 · 12ff246
1 parent bac37ca
commit 12ff246
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/popular-shrimps-give.md b/.changeset/popular-shrimps-give.md
@@ -0,0 +1,5 @@
+---
+'slate-react': minor
+---
+
+Fixed occasional crashes when selecting void elements in Chrome
diff --git a/packages/slate-react/src/plugin/react-editor.ts b/packages/slate-react/src/plugin/react-editor.ts
@@ -869,7 +869,8 @@ export const ReactEditor: ReactEditorInterface = {
     // will cause `toSlatePoint` to throw an error. (2023/03/07)
     if (
       'getAttribute' in focusNode &&
-      (focusNode as HTMLElement).getAttribute('contenteditable') === 'false'
+      (focusNode as HTMLElement).getAttribute('contenteditable') === 'false' &&
+      (focusNode as HTMLElement).getAttribute('data-slate-void') !== 'true'
     ) {
       focusNode = anchorNode
       focusOffset = anchorNode.textContent?.length || 0