Fix deep-equality for array properties (#4672)

ianstormtaylor · Nov 22, 2021 · 2523dc4 · 2523dc4
1 parent 0540fea
commit 2523dc4
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 6 deletions.
diff --git a/.changeset/merge-nodes-issue b/.changeset/merge-nodes-issue
diff --git a/.changeset/wicked-mayflies-approve.md b/.changeset/wicked-mayflies-approve.md
@@ -0,0 +1,5 @@
+---
+'slate': minor
+---
+
+Fix - deep-equals was always returning true when array props were equals.
diff --git a/packages/slate/src/utils/deep-equal.ts b/packages/slate/src/utils/deep-equal.ts
@@ -24,7 +24,6 @@ export const isDeepEqual = (
       for (let i = 0; i < a.length; i++) {
         if (a[i] !== b[i]) return false
       }
-      return true
     } else if (a !== b) {
       return false
     }

diff --git a/packages/slate/test/utils/deep-equal/deep-equals-with-array.js b/packages/slate/test/utils/deep-equal/deep-equals-with-array.js
@@ -0,0 +1,20 @@
+import { isDeepEqual } from '../../../src/utils/deep-equal'
+
+export const input = {
+  objectA: {
+    text: 'same text',
+    array: ['array-content'],
+    bold: true,
+  },
+  objectB: {
+    text: 'same text',
+    array: ['array-content'],
+    bold: true,
+  },
+}
+
+export const test = ({ objectA, objectB }) => {
+  return isDeepEqual(objectA, objectB)
+}
+
+export const output = true
diff --git a/packages/slate/test/utils/deep-equal/deep-not-equals-with-array.js b/packages/slate/test/utils/deep-equal/deep-not-equals-with-array.js
@@ -0,0 +1,20 @@
+import { isDeepEqual } from '../../../src/utils/deep-equal'
+
+export const input = {
+  objectA: {
+    text: 'same text',
+    array: ['array-content'],
+    bold: true,
+  },
+  objectB: {
+    text: 'same text',
+    array: ['array-content'],
+    bold: false,
+  },
+}
+
+export const test = ({ objectA, objectB }) => {
+  return isDeepEqual(objectA, objectB)
+}
+
+export const output = false