Fix deletion of selected inline void nodes in Safari (#4331)

Co-authored-by: Claudéric Demers <clauderic.d@gmail.com>
ianstormtaylor · Jun 9, 2021 · a3bc97a · a3bc97a
1 parent 6c99352
commit a3bc97a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/safari-delete-inlinevoid.md b/.changeset/safari-delete-inlinevoid.md
@@ -0,0 +1,5 @@
+---
+'slate-react': patch
+---
+
+Fix deletion of selected inline void nodes in Safari when presssing `backspace` or `delete`. This is a bug that [was originally fixed only for Google Chrome](https://github.com/ianstormtaylor/slate/issues/3456), but the fix also needs to be applied in Safari.
diff --git a/packages/slate-react/src/components/editable.tsx b/packages/slate-react/src/components/editable.tsx
@@ -1066,8 +1066,8 @@ export const Editable = (props: EditableProps) => {
                     return
                   }
                 } else {
-                  if (IS_CHROME) {
-                    // COMPAT: Chrome supports `beforeinput` event but does not fire
+                  if (IS_CHROME || IS_SAFARI) {
+                    // COMPAT: Chrome and Safari support `beforeinput` event but do not fire
                     // an event when deleting backwards in a selected void inline node
                     if (
                       selection &&