Fix deletion of expanded range (#4549)

ianstormtaylor · Sep 26, 2021 · f9c41a5 · f9c41a5
1 parent 95e13b0
commit f9c41a5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/modern-toes-invent.md b/.changeset/modern-toes-invent.md
@@ -0,0 +1,5 @@
+---
+'slate-react': patch
+---
+
+Fix deletion of expanded range (#4546)
diff --git a/packages/slate-react/src/components/editable.tsx b/packages/slate-react/src/components/editable.tsx
@@ -310,6 +310,10 @@ export const Editable = (props: EditableProps) => {
           }
         }
 
+        if (!native) {
+          event.preventDefault()
+        }
+
         // COMPAT: For the deleting forward/backward input types we don't want
         // to change the selection because it is the range that will be deleted,
         // and those commands determine that for themselves.
@@ -424,7 +428,7 @@ export const Editable = (props: EditableProps) => {
               // Potentially expand to single character deletes, as well.
               if (native) {
                 asNative(editor, () => Editor.insertText(editor, data), {
-                  onFlushed: () => (native = false),
+                  onFlushed: () => event.preventDefault(),
                 })
               } else {
                 Editor.insertText(editor, data)
@@ -434,10 +438,6 @@ export const Editable = (props: EditableProps) => {
             break
           }
         }
-
-        if (!native) {
-          event.preventDefault()
-        }
       }
     },
     [readOnly, propsOnDOMBeforeInput]