Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI is now breaking due to node 10 / upath bug #1795

Closed
jasonphillips opened this issue Apr 25, 2018 · 1 comment
Closed

CI is now breaking due to node 10 / upath bug #1795

jasonphillips opened this issue Apr 25, 2018 · 1 comment
Labels
debt ♥ help

Comments

@jasonphillips
Copy link
Contributor

Check out these failing Travis builds across latest PRs:

https://travis-ci.org/ianstormtaylor/slate/jobs/371132970
https://travis-ci.org/ianstormtaylor/slate/jobs/371138323

The problem shows up here:
image

And is caused by Travis now grabbing the latest Node release, which as of today is 10.0:
image

The underlying issue has been noted on upath, here:
anodynos/upath#14

To resolve it, we either need to manually specify a different version of node for Travis, or update yarn install to use the --ignore-engines flag.
@jasonphillips jasonphillips mentioned this issue Apr 25, 2018
Merged
@ianstormtaylor
Copy link
Owner

Thanks for the heads up @jasonphillips. Just fixed on master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt ♥ help
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianstormtaylor @jasonphillips