Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider dropping IE11 support at some point #2029

Closed
ianstormtaylor opened this issue Aug 2, 2018 · 4 comments
Closed

consider dropping IE11 support at some point #2029

ianstormtaylor opened this issue Aug 2, 2018 · 4 comments

Comments

@ianstormtaylor
Copy link
Owner

Do you want to request a feature or report a bug?

Debt.

What's the current behavior?

There are IE11-specific hacks in the codebase, and it's really becoming an outdated browser. Thread on Twitter. Khan Academy officially dropped support for it.

The thing is, for non-rich text behaviors, supporting IE11 isn't as hard, since you can just polyfill things like el.closest or whatever. For but rich-text, you need proper copy/paste support, proper range creation/updating support, proper input event support, etc. Things that are much harder, if not impossible to polyfill.

What's the expected behavior?

Not a current priority, but at some point in some amount of months it'll probably make sense to drop support for it and remove the IE11 hacks from the codebase. This will be even more important as we look to start supporting the newer beforeinput event APIs.

@schneidmaster
Copy link
Collaborator

Totally understand the motivations here, but I'd love if we could at least just extract the hacks into a separate package or something. If you're using Slate in any sort of enterprise software then the reality is that you're still stuck supporting IE11 probably until Microsoft kills it (it's still a double-digit percentage of browser share for users in corporate environments, most of whom are restricted from using a better browser by security policies).

@mike-hewitson
Copy link

Wow. While I also understand, we've also got the challenge of supporting IE11 as well. On that vein, I cannot open slatejs.org in IE11, so it looks like compatibility is already gone/compromised? All other browsers (including Edge 15) seem fine.

@nikushx
Copy link

nikushx commented May 22, 2019

@mike-hewitson I believe that's because the main Slate package won't include the polyfills for IE11, you need to add them yourself

@ianstormtaylor ianstormtaylor mentioned this issue Nov 6, 2019
@ianstormtaylor
Copy link
Owner Author

Fixed by #3093.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants