Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transforms.wrapNodes and Transfroms.unwrapNodes causing the entire parent node to re-render #3748

Open
zbeyens opened this issue Jun 24, 2020 · 0 comments
Open

Transforms.wrapNodes and Transfroms.unwrapNodes causing the entire parent node to re-render #3748

zbeyens opened this issue Jun 24, 2020 · 0 comments

Comments

@zbeyens
Copy link
Contributor

zbeyens commented Jun 24, 2020

Bug

Description

Transforms.wrapNodes and Transfroms.unwrapNodes causing the entire parent node to re-render

How to reproduce

https://codesandbox.io/s/slate-plugins-reproductions-bug-177-vo206

Add list items right above embed and now add nested list items. embed component gets rerendered and causes another network request.

Expected behavior

If the URL for embed is not changed component should not be re-rendered so we can avoid network request Also, re-render impacts UX.

Workaround

The current workaround is to avoid using these transforms.

More informations there udecode/plate#177

It may be related to #3740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zbeyens