-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backwards text typing on empty, nested, editable void Slate Editor #4293
Comments
The change to `exactMatch: false` in ianstormtaylor#4304 was intended to fix ianstormtaylor#4293, a bug where "backwards typing" happened in nested editors. But this change has introduced at least two new bugs: - ianstormtaylor#4601 - ianstormtaylor#4626 These are (IMO) worse than the original "backwards typing" bug. From discussion in ianstormtaylor#4304, the true underlying bug is in ReactEditor.toSlateRange. I'll attempt to fix this underlying bug instead.
* Revert "Do NOT use exact match when updating dom selection" The change to `exactMatch: false` in #4304 was intended to fix #4293, a bug where "backwards typing" happened in nested editors. But this change has introduced at least two new bugs: - #4601 - #4626 These are (IMO) worse than the original "backwards typing" bug. From discussion in #4304, the true underlying bug is in ReactEditor.toSlateRange. I'll attempt to fix this underlying bug instead. * changeset
Can this ticket please be re-opened, as the fix was reverted? We need nested editable voids in our app, and we are suffering the cursor bug. Also, is there a workaround I can use until it is fixed? |
this is also extremely problematic for us. having nested editable voids is a big part of our app but this bug makes the nested editor unusable. is there anything we can do try to normalize or force the selection while the root is being addressed? |
This is causing major issues for our product too. It totally breaks one of our core integrations. |
Description
When there is NO text, yet within a nested, editoable void Slate Editor (see editable voids example, starting to type some text leads to backwards typing.
Recording
Sandbox
Can be reproduced in the editable voids example.
Steps
To reproduce the behavior:
Expectation
Text should be added as it is typed
Environment
Context
This might be connected to #4275
The text was updated successfully, but these errors were encountered: