refactor slate-hotkeys, fix deleting at start of block #2048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
Bug & debt.
What's the new behavior?
Refactor's the
slate-hotkeys
package to make it easier to reason about, and fix an issue that was present in the delete hotkeys on macs.How does this change work?
Use a simpler map of hotkeys instead of writing functions inline. This is possible thanks to the new version of
is-hotkey
with optional hotkeys and multiple hotkeys features.Have you checked that...?
yarn test
.yarn lint
. (Fix errors withyarn prettier
.)yarn watch
.)Does this fix any issues or need any specific reviewers?
Fixes: #1887
Fixes: #1888
Fixes: #1983