Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unicode offset #3044

Merged

Conversation

davidhoeller
Copy link
Contributor

@davidhoeller davidhoeller commented Sep 30, 2019

Is this adding or improving a feature or fixing a bug?

This is basically PR #2680 in the current version of slate (Fixes #2635, fixes #2632)
Thanks @adjourn for starting this.
Plus, fixes a bug where the cursor could not be moved beyond block with arrow keys.

What's the new behavior?

As explained in #2680 .
The emoji example has been extended to insert emojis as plain text (vs inline nodes) to demonstrate the new behaviour.

How does this change work?

See #2680
Updated emoji example, see here:
Slate PR-3044 Fix unicode offset Example

Have you checked that...?

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn prettier.)
  • The relevant examples still work. (Run examples with yarn watch.)

Does this fix any issues or need any specific reviewers?

Fixes: #2635, #2632
Reviewers: @adjourn @ianstormtaylor @kwokhuen

@ianstormtaylor
Copy link
Owner

Thanks @davidhoeller for update this! And huge thank you to @adjourn for taking the time to fix this in the first place.

@ianstormtaylor ianstormtaylor merged commit 8dce753 into ianstormtaylor:master Oct 6, 2019
@sammylupt
Copy link

Thank you so much!

@rinoc rinoc mentioned this pull request Dec 12, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants