Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
This is basically PR #2680 in the current version of slate (Fixes #2635, fixes #2632)
Thanks @adjourn for starting this.
Plus, fixes a bug where the cursor could not be moved beyond block with arrow keys.
What's the new behavior?
As explained in #2680 .
The emoji example has been extended to insert emojis as plain text (vs inline nodes) to demonstrate the new behaviour.
How does this change work?
See #2680
Updated emoji example, see here:
Have you checked that...?
yarn test
.yarn lint
. (Fix errors withyarn prettier
.)yarn watch
.)Does this fix any issues or need any specific reviewers?
Fixes: #2635, #2632
Reviewers: @adjourn @ianstormtaylor @kwokhuen