Skip wrapping nodes when the only match is an editor #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dfbd20e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
spocke
approved these changes
May 10, 2021
dylans
approved these changes
Aug 4, 2021
This was referenced Aug 5, 2021
Merged
dylans
pushed a commit
to dylans/slate
that referenced
this pull request
Sep 13, 2021
…4253) * Skip wrapping nodes when the only match is an editor * Check for empty path instead of using isEditor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transforms.wrapNodesattempts to detect when zero nodes match, but it missed an edge case where one node matches - the editor. The function very quickly throwsError: Cannot get the parent path of the root path []when this happens.Example
The test shows the failure condition. The editor I'm working on supports
contenteditable=falsesections in document content, and while we are able to handle most of the filtering outside of slate this is one case that is difficult to handle without a lot of extra code.Context
There are a few other ways I can think of to fix this - such as wrapping the supplied
matchfunction to enforce!Editor.isEditor- but this seemed like the least invasive way to deal with it.Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)