Don't remove selection when hovering over a non-selectable DOM element #4577
Conversation
Fixes ianstormtaylor#4545 To reproduce the buggy behavior: 1. Create a page that renders a Slate element with a `contentEditable: false` element in it. 2. Start selecting some text with the mouse. 3. During the drag, mouseover the `contentEditable: false` element. Expected behavior: After doing a drag-to-select with the mouse, from a valid anchor point on mousedown to a valid focus point on mouseup, the selection is set to those anchor and focus points. Actual behavior: your selection is removed as soon as your mouse hits the `contentEditable: false` element. This is because the current behavior clears the selection if it is momentarily not a valid Slate location.
🦋 Changeset detectedLatest commit: 4389d16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I discovered that this bug can be seen in a standard Slate example: https://www.slatejs.org/examples/check-lists. When selecting text, mouseover one of the checkboxes. You'll see that the selection is removed. Compare the same example with this patch, which does not have this buggy behavior: https://deploy-preview-4577--slatejs.netlify.app/examples/check-lists |
jameshfisher
changed the title
There was a problem hiding this comment.
This seems reasonable. Not sure if it might introduce a scenario where you cannot clear out the selection, but I don't see that being the case with some quick tests. I'll leave it open for a few days for others to give feedback.
Could you add a quick changeset please? (yarn changeset from your branch, or there's an option in the GitHub UI). Thanks!
Description
To reproduce the buggy behavior:
contentEditable: falseelement in it.contentEditable: falseelement.Expected behavior: After doing a drag-to-select with the mouse, from a valid anchor point on mousedown to a valid focus point on mouseup, the selection is set to those anchor and focus points.
Actual behavior: your selection is removed as soon as your mouse hits the
contentEditable: falseelement. This is because the current behavior clears the selection if it is momentarily not a valid Slate location.Recording of buggy behavior
mouseover-bug.mp4
Issue
Fixes #4545
Context
If the focus is momentarily not a valid Slate location, just do nothing.
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)