Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update editable.tsx: auto-focus fix for end of line with several chil… #4695

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update editable.tsx: auto-focus fix for end of line with several chil… #4695

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f1d1ceb
Update editable.tsx: auto-focus fix for end of line with several chil…
GrinchakAndrew Nov 27, 2021
45077f6
tweak node to ref.current
GrinchakAndrew Nov 29, 2021
d88f2ee
Update packages/slate-react/src/components/editable.tsx
dylans Jan 11, 2022
6f2e342
Update editable.tsx
dylans Jan 11, 2022
012ae90
Add changeset
dylans Jan 11, 2022
127fba3
Merge branch 'main' into main
dylans Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/slate-react/src/components/editable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,20 @@ export const Editable = (props: EditableProps) => {
// The autoFocus TextareaHTMLAttribute doesn't do anything on a div, so it
// needs to be manually focused.
useEffect(() => {
if (ref.current && autoFocus) {
ref.current.focus()
}
}, [autoFocus])
if (ref.current && autoFocus) {
if(window.getSelection && document.createRange) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prettify the diff. This if needs a space after it.

dylans marked this conversation as resolved.
Show resolved Hide resolved
const range = document.createRange();
ref.current.focus();
Copy link

@akonsu akonsu Dec 5, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it essential to call ref.current.focus() here and not at the end of this if clause? Maybe we can move this call out of the if statement (from both this clause and the else clause)?

range.setStart(ref.current, ref.current.childNodes.length);
range.setEnd(ref.current, ref.current.childNodes.length);
const sel = window.getSelection();
sel.removeAllRanges();
sel.addRange(range);
}
else
ref.current.focus();
}
}, [autoFocus])

// Listen on the native `selectionchange` event to be able to update any time
// the selection changes. This is required because React's `onSelect` is leaky
Expand Down