Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix void node clipboard event handling in Firefox #4775

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix void node clipboard event handling in Firefox #4775

wants to merge 2 commits into from
+52 −2

Commits on Jan 7, 2022

  1. fix: Fix broken clipboard event handling with void nodes in Firefox 

    COMPAT: Firefox will not trig clipboard events when selections ends in void nodes.
Make sure that the range has 0-1 (not 1-1) offset so something is selected.
This obviously works fine in other browsers. Related to the zero-value (\uFEFF)?
    @skogsmaskin
    skogsmaskin committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    00557b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. fix: handle up/down key navigation over void nodes with custom code 

    Handle up down key navigation over void nodes with this specific behaviour.
In this way we have a consistent way of handling these events, and it will not be up to the default browser behaviour to move the cursor.

Firefox seems to handle this a bit differently than the other browsers.
After doing e96a833 you had to press up/down twice to move the focus up/down between void blocks.
    @skogsmaskin
    skogsmaskin committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    a7a2a30 View commit details
    Browse the repository at this point in the history