Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text content not rendered on ssr #4798

Merged
merged 1 commit into from Jan 22, 2022

Conversation

hueyhe
Copy link
Contributor

@hueyhe hueyhe commented Jan 21, 2022

Description
The fix makes sure that the text content of the TextString component is rendered on the first render.

Issue
Fixes: server-side rendering issue introduced by #4733.
Correct fix of #4796.

Example
Please see example in #4796.

Context
#4733 spellcheck fix changed the render behavior of the TextString component. TextString won't render the actual text content on the first-time render, which means server-side rendering is broken. This fix ensures that the text content will get rendered immediately on the first-time render.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2022

🦋 Changeset detected

Latest commit: 0e7515a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit 3796c51 into ianstormtaylor:main Jan 22, 2022
@github-actions github-actions bot mentioned this pull request Jan 22, 2022
DougReeder pushed a commit to DougReeder/slate that referenced this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants