Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Triple click selection and copy&paste in read-only mode #4914

Merged
merged 8 commits into from
Apr 3, 2022
Merged

Fixed Triple click selection and copy&paste in read-only mode #4914

merged 8 commits into from
Apr 3, 2022

Conversation

sennpang
Copy link
Contributor

@sennpang sennpang commented Mar 25, 2022 •
edited
Loading

Description
Triple click selection and copy&paste in read-only mode

Issue
Fixes: #4897 #3871

Example
before:
https://user-images.githubusercontent.com/66263028/158982608-bada507e-2249-4b70-9c6c-906f687ee36a.mov
after:
https://user-images.githubusercontent.com/16861647/160055330-4df1837d-c364-4bc8-96e0-f4a5297c740e.mov

Context

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 1c369c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
slate-react Patch
slate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dylans
dylans requested changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestion. Also please add a changeset. Thanks!

packages/slate-react/src/components/editable.tsx Outdated Show resolved Hide resolved
@sennpang sennpang requested a review from dylans April 2, 2022 06:29
dylans
dylans requested changes Apr 3, 2022
View reviewed changes
.changeset/khaki-candles-serve.md Outdated Show resolved Hide resolved
.changeset/khaki-candles-serve.md Outdated Show resolved Hide resolved
@dylans dylans merged commit aff6731 into ianstormtaylor:main Apr 3, 2022
@github-actions github-actions bot mentioned this pull request Apr 3, 2022
Merged
@sennpang sennpang deleted the fixed4897 branch April 6, 2022 06:23
@sennpang sennpang mentioned this pull request Apr 7, 2022
Open
@scottlu scottlu mentioned this pull request Apr 8, 2022
Closed
@BitPhinix BitPhinix mentioned this pull request Apr 25, 2022
Merged
5 tasks
@jnath jnath mentioned this pull request Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylans dylans dylans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Triple click selection and copy&paste in read-only mode
2 participants
@sennpang @dylans