Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Editable not calling decorate as it should #5346

Merged

Conversation

edhager
Copy link
Contributor

@edhager edhager commented Mar 7, 2023

Fixes this problem:

  1. On an Android phone, open the "Search Highlighting" example page.
  2. Search for test. For example, "search".
  3. Place the cursor immediately after one of the highlighted strings.
  4. Type additional text.

The additional text will be highlighted as if it matched the search string.

The problem was Editable was not calling the decorate function that was passed to it when it should.

One thing to note with the fix. If you follow the steps above and you type additional text quickly, some of it will appear highlighted for a split second. The gif below demonstrates that.

2023-03-07 15 23 16

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2023

🦋 Changeset detected

Latest commit: a7a1c2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit a5e833f into ianstormtaylor:main Mar 8, 2023
@github-actions github-actions bot mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants