enable eslint hooks rules #5363
Conversation
🦋 Changeset detectedLatest commit: 40e1ab8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aciccarello
force-pushed
the
eslint-react-hooks
branch
from
ed70814
to
9426621
Compare
| @@ -19,7 +20,7 @@ | |||
| "settings": { | |||
| "import/extensions": [".js", ".ts", ".jsx", ".tsx"], | |||
| "react": { | |||
| "version": "detect" | |||
| "version": "16" | |||
There was a problem hiding this comment.
I think yarn was causing detect to not work
aciccarello
force-pushed
the
eslint-react-hooks
branch
from
9426621
to
9b0cb1a
Compare
| renderElement={({ element, children }) => { | ||
| React.useEffect(() => mounts(element), []) | ||
| renderElement={({ children }) => { | ||
| useEffect(() => mounts(), []) |
There was a problem hiding this comment.
This is meant to be testing the mount call count (hence the empty dependency) but we were passing the element which eslint wants included in the dependency array. It's not needed for the test.
packages/slate-react/src/hooks/android-input-manager/use-android-input-manager.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Overall looks good, it looks like @jason0x43's feedback covers everything I would have suggested, so please let me know when you've addressed the other feedback. Thanks!
aciccarello
force-pushed
the
eslint-react-hooks
branch
from
e004acc
to
40e1ab8
Compare
Description
A clear and concise description of what this pull request solves. (Please do not just link to a long issue thread. Instead include a clear description here or your pull request will likely not be reviewed as quickly.)
Issue
Fixes: (link to issue)
Example
A GIF or video showing the old and new behaviors after this pull request is merged. Or a code sample showing the usage of a new API. (If you don't include this, your pull request will not be reviewed as quickly, because it's much too hard to figure out exactly what is going wrong, and it makes maintenance much harder.)
Context
If your change is non-trivial, please include a description of how the new logic works, and why you decided to solve it the way you did. (This is incredibly helpful so that reviewers don't have to guess your intentions based on the code, and without it your pull request will likely not be reviewed as quickly.)
Closes #3886
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)