Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caret jump to the start of composition string #5443

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

OldDream
Copy link
Contributor

@OldDream OldDream commented Jun 9, 2023

Description
Correct caret position during composition.
When useIsomorphicLayoutEffect was triggered during composition, caret would jump to wrong position (jump to the start).
This commit fix the bug when using chinese IME.

More info about the bug is in the issue.

Issue
Fixes: #5442

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

🦋 Changeset detected

Latest commit: 95c39a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@OldDream OldDream changed the title fix: caret jump to the start of composition str fix: caret jump to the start of composition string Jun 9, 2023
Copy link
Collaborator

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, reminds me that we really need to make progress on a test suite.

@OldDream could you please add a changeset per the instructions and we'll land this in the next version?

@OldDream OldDream requested a review from dylans June 12, 2023 02:59
@dylans dylans merged commit eb7f598 into ianstormtaylor:main Jun 12, 2023
12 checks passed
This was referenced Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong caret position when using chinese IME with async state change.
2 participants