Add onSelectionChange and onValueChange in Slate React component
#5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbeyens
suggested changes
Oct 19, 2023
| }) | ||
| await act(async () => Transforms.insertText(editor, 'Hello word!')) | ||
| expect(onValueChange).toHaveBeenCalled() | ||
| }) |
There was a problem hiding this comment.
Could you add
expect(onChange).toHaveBeenCalled()
expect(onSelectionChange).toHaveBeenCalled()And another test using Transforms.setNodes that should not change selection?
There was a problem hiding this comment.
I added a unit test case using Transforms.setNodes to set the text as bold. Is that okay?
5 tasks
Thank you for your suggestion. I will make the changes as soon as possible |
Add more unit tests.
jkcs
changed the title
onSelectorChange and onValueChange in Slate React componentonSelectionChange and onValueChange in Slate React component
This was referenced Oct 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
onSelectionChangeandonValueChangein Slate React componentIssue
Fixes: #5521
/claim udecode/plate#2700
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)